servicetalk / PR 3650
Use assertThrows instead of try/fail/catch in tests
apple/servicetalk#3650 mergedtest-only
+200/−444lines
31files
7comments
2026-09-23opened
2026-09-28merged
What it touches
test: 31
Modules: servicetalk-concurrent-api (14), servicetalk-concurrent-api-internal (3), servicetalk-http-netty (3), servicetalk-transport-netty-internal (2), servicetalk-client-api-internal (1), servicetalk-client-api (1)
Architectural impact (arcade-agent diff_impact)
No production Java file of this PR maps into the dependency graph (tests, build, CI or docs only). Tests are excluded from the graph by design.
Files
| test | servicetalk-client-api-internal/src/test/java/io/servicetalk/client/api/internal/partition/DefaultPartitionAttributesBuilderTest.java |
| test | servicetalk-client-api/src/test/java/io/servicetalk/client/api/LimitingConnectionFactoryFilterTest.java |
| test | servicetalk-concurrent-api-internal/src/test/java/io/servicetalk/concurrent/api/ExecutorRejectionTest.java |
| test | servicetalk-concurrent-api-internal/src/test/java/io/servicetalk/concurrent/api/internal/ConnectableBufferOutputStreamTest.java |
| test | servicetalk-concurrent-api-internal/src/test/java/io/servicetalk/concurrent/api/internal/ConnectablePayloadWriterTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherAsBlockingIterableTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/SequentialSubscriptionTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/completable/AbstractWhenCancelTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/completable/AbstractWhenFinallyTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/completable/CollectTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/AbstractWhenCancelTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/AbstractWhenFinallyTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/AbstractWhenRequestTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/publisher/AfterFinallyTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/single/AbstractWhenCancelTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/single/AbstractWhenFinallyTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/single/CollectTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/api/single/FutureToSingleTest.java |
| test | servicetalk-concurrent-api/src/test/java/io/servicetalk/concurrent/internal/ConcurrentSubscriptionTest.java |
| test | servicetalk-data-jackson-jersey/src/test/java/io/servicetalk/data/jackson/jersey/JacksonSerializationExceptionMapperTest.java |
| test | servicetalk-data-jackson/src/test/java/io/servicetalk/data/jackson/JacksonSerializationProviderTest.java |
| test | servicetalk-grpc-netty/src/test/java/io/servicetalk/grpc/netty/ProtocolCompatibilityTest.java |
| test | servicetalk-http-api/src/test/java/io/servicetalk/http/api/BlockingStreamingToStreamingServiceTest.java |
| test | servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/BlockingStreamingHttpServiceTest.java |
| test | servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/FlushStrategyForClientApiTest.java |
| test | servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/NettyHttpServerTest.java |
| test | servicetalk-http-router-predicate/src/test/java/io/servicetalk/http/router/predicate/HttpPredicateRouterBuilderTest.java |
| test | servicetalk-loadbalancer/src/test/java/io/servicetalk/loadbalancer/LoadBalancerTest.java |
| test | servicetalk-serialization-api/src/test/java/io/servicetalk/serialization/api/DefaultSerializerDeserializationTest.java |
| test | servicetalk-transport-netty-internal/src/test/java/io/servicetalk/transport/netty/internal/RequestResponseCloseHandlerTest.java |
| test | servicetalk-transport-netty-internal/src/test/java/io/servicetalk/transport/netty/internal/WriteStreamSubscriberOutOfEventloopTest.java |