pkl / PR 980

Fix hash code computation of cyclical objects

apple/pkl#980 openmixed

+189/−65lines
24files
0comments
2025-02-24opened
-merged

What it touches

main: 17 test: 7

Modules: pkl-core (24)

Architectural impact (arcade-agent diff_impact)

17files mapped to the graph
398entities in those files
Corecomponents
2244entities within 3 hops downstream

Most depended-upon changed entities

EntityDependents
org.pkl.core.runtime.VmClass273
org.pkl.core.runtime.VmList243
org.pkl.core.runtime.VmDataSize236
org.pkl.core.runtime.VmDuration234
org.pkl.core.runtime.VmDynamic154
org.pkl.core.runtime.VmListing135
org.pkl.core.runtime.VmIntSeq77
org.pkl.core.runtime.StdLibModule16

Computed against the current default branch, not the PR base commit; files renamed or deleted since then are unmatched. Downstream counts are a reverse-dependency closure to depth 3 and over-approximate real blast radius.

Files

mainpkl-core/src/main/java/org/pkl/core/runtime/StdLibModule.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmClass.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmDataSize.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmDuration.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmDynamic.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmIntSeq.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmList.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmListing.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmMap.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmMapping.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmNull.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmObject.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmPair.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmRegex.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmSet.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmTyped.java
mainpkl-core/src/main/java/org/pkl/core/runtime/VmValue.java
testpkl-core/src/test/files/LanguageSnippetTests/input/listings/hashCode.pkl
testpkl-core/src/test/files/LanguageSnippetTests/input/mappings/hashCode.pkl
testpkl-core/src/test/files/LanguageSnippetTests/input/objects/hashCode.pkl
testpkl-core/src/test/files/LanguageSnippetTests/output/listings/hashCode.pcf
testpkl-core/src/test/files/LanguageSnippetTests/output/mappings/hashCode.pcf
testpkl-core/src/test/files/LanguageSnippetTests/output/objects/hashCode.pcf
testpkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt